feat: valid Pydantic #373
Closed
feat: valid Pydantic #373
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieroit
requested changes
Jul 21, 2023
| # set a different LLM | ||
| invented_url = "https://example.com" | ||
| payload = {} |
| return get_setting_by_name(payload.name) | ||
|
|
||
| def validate_presences(required: list, payload: dict): |
There was a problem hiding this comment.
Agree with the utility of a validate_presences method, but it is not related to DB crud.
I would move it here in the factory, where schemas are defined, or in utilis in case we'll use this validation method also for plugin settings. Also infrastructure could be a place for this method, if we go for a validation set of methods
What do you think?
| @@ -54,7 +54,17 @@ def upsert_embedder_setting( | |||
| status_code=400, | |||
| detail=f"{languageEmbedderName} not supported. Must be one of {allowed_configurations}", | |||
| ) | |||
|
|
|||
|
|
|||
| required = EMBEDDER_SCHEMAS[languageEmbedderName]['required'] | |||
There was a problem hiding this comment.
is there always a required key?
| required = EMBEDDER_SCHEMAS[languageEmbedderName]['required'] | ||
| if crud.validate_presences(required, payload): | ||
| raise HTTPException( | ||
| status_code=405, |
|
|
||
| # check immediate response | ||
| assert response.status_code == 405 |
# Conflicts: # core/cat/routes/setting/embedder_setting.py # core/cat/routes/setting/llm_setting.py # core/tests/routes/setting/test_llm_setting.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I verify that I
requiredof pydantic is respected in payloads with validate_presencesRelated to issue #(cheshire-cat-ai/admin-vue#27)
Type of change
Checklist: